Add support for ggalt::geom_dumbbell. #1782
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trekonom
changed the title
cpsievert
reviewed
Jun 1, 2020
cpsievert
reviewed
Jun 1, 2020
cpsievert
reviewed
Jun 1, 2020
|
Hi Carson. First. Sorry for messing up the commit history.
Best, Stefan |
Merged
|
I just added the visual tests to the PR. However, running the visual tests against the docker image failed with the message "there is no package called 'ggalt'". If I should guess ... this probably happens because |
|
Ah, yea, let's add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
ggalt::geom_dumbbelland closes #1454 .The implementation follows
ggalt::GeomDumbbell.Tooltips only show up if hovering over the points and differ for the left and right point. To this end I added a util function
make_hovertextwhich overwrites the hovertext set bylayers2traces.I also added some tests and tried to add a visual test (which however failed when running the test while vdiffr::manage_cases showed me a successful doppelganger). Therefore the visual test is commented out in the test.