-
-
Notifications
You must be signed in to change notification settings - Fork 544
syncing footer urls with plotly/next #1467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if there were any changes since https://github.com/plotly/plotly-next/issues/442#issue-475840131 but if there weren't, I've left a few changes below.
@michaelbabyn This PR mirrors the footer that is currently live on https://plot.ly in terms of the inclusion of |
@VeraZab , do you have any insight on why the changes made to plotly/next from https://github.com/plotly/plotly-next/issues/442#issue-475840131 don't appear to have taken effect? I.e the link to "developer support" is still there and the documentation link still points to help.plot.ly. |
i'm really not sure why this happened, but i see that we had 2 pathways through which we decided how to make our footer look (Prismic, and one hardcoded). |
the right footer info is on the site now! thanks @michaelbabyn for realizing it. don't know what happened, but its hardcoded now, so it should all be easier to maintain. |
@michaelbabyn Here is a screenshot of the footer, synced with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, @jdamiba. 💃
This PR syncs the footer URLs in this repo with those in
plotly-next
.This should have been accomplished by #1438 but either I made a mistake or the URLs have changed in the interim, or both.