Skip to content

syncing footer urls with plotly/next #1467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2019
Merged

Conversation

jdamiba
Copy link
Contributor

@jdamiba jdamiba commented Aug 20, 2019

This PR syncs the footer URLs in this repo with those in plotly-next.

This should have been accomplished by #1438 but either I made a mistake or the URLs have changed in the interim, or both.

Screen Shot 2019-08-20 at 2 07 22 PM

@jdamiba jdamiba requested a review from michaelbabyn August 20, 2019 18:16
Copy link
Contributor

@michaelbabyn michaelbabyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if there were any changes since https://github.com/plotly/plotly-next/issues/442#issue-475840131 but if there weren't, I've left a few changes below.

@jdamiba
Copy link
Contributor Author

jdamiba commented Aug 20, 2019

@michaelbabyn This PR mirrors the footer that is currently live on https://plot.ly in terms of the inclusion of Developer Support and the URL for Documentation. Given that https://github.com/plotly/plotly-next/issues/442 was closed 18 days ago, I think that what is live today represents the standard that should be synced to?

@michaelbabyn
Copy link
Contributor

@VeraZab , do you have any insight on why the changes made to plotly/next from https://github.com/plotly/plotly-next/issues/442#issue-475840131 don't appear to have taken effect? I.e the link to "developer support" is still there and the documentation link still points to help.plot.ly.

@VeraZab
Copy link
Contributor

VeraZab commented Aug 21, 2019

i'm really not sure why this happened, but i see that we had 2 pathways through which we decided how to make our footer look (Prismic, and one hardcoded).
i'm making a pr that hardcodes all the links now, so there's less future mystery around that.
i'll put this live in a few mins and these adjustments should be live.

@VeraZab
Copy link
Contributor

VeraZab commented Aug 21, 2019

the right footer info is on the site now! thanks @michaelbabyn for realizing it. don't know what happened, but its hardcoded now, so it should all be easier to maintain.

@jdamiba
Copy link
Contributor Author

jdamiba commented Aug 22, 2019

@michaelbabyn Here is a screenshot of the footer, synced with plotly-next (current state of this PR):

Screen Shot 2019-08-22 at 8 17 02 AM

Copy link
Contributor

@michaelbabyn michaelbabyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, @jdamiba. 💃

@jdamiba jdamiba merged commit 4f3c80d into source-design-merge Aug 22, 2019
@jdamiba jdamiba deleted the footer-fixup branch August 22, 2019 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants