Skip to content

added geom_hex #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 15, 2019
Merged

added geom_hex #1434

merged 6 commits into from
Aug 15, 2019

Conversation

kojisposts
Copy link
Contributor

No description provided.

Copy link
Contributor

@michaelbabyn michaelbabyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good @bobidou23 , after small changes to make sure these examples are all runnable 💃

```{r, results='hide'}
library(plotly)

p <- ggplot(english_french, aes(x=engperc,y=frenperc)) +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if english_french was assigned in this example too so that the code here could run independently of the first one.

```{r, results='hide'}
library(plotly)

p <- ggplot(english_french, aes(x=engperc, y=frenperc, weight=total)) +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as above re: english_french

```{r, results='hide'}
library(plotly)

p <- ggplot(english_french, aes(x=engperc,y=frenperc, weight=total)) +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, if we could assign english_french in this example before using it, that would be great.

@michaelbabyn
Copy link
Contributor

Thanks @bobidou23 , feel free to merge this! 💃

@kojisposts kojisposts merged commit f60fdd8 into source-design-merge Aug 15, 2019
@kojisposts kojisposts deleted the geom_hex branch August 15, 2019 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants