indicator js tutorial #1422
indicator js tutorial #1422
Conversation
There was a problem hiding this comment.
Overall this looks good @Mahdis-z. Adding page_type: example_index and the two redirects I mentioned should be good to get this approved from my end.
I also want to make sure that leaving the title/name as Guage Charts was intentional and not an oversight.
We should change the name to Indicators for this example and we should create a new thumbnail as well.
| redirect_from: javascript-graphing-library/gauge-charts/ | ||
| display_as: financial | ||
| order: 4 | ||
| redirect_from: javascript-graphing-library//indicator |
There was a problem hiding this comment.
we shouldn't change this redirect here as we still want to redirect javascript-graphing-library/gauge-charts/ -> javascript/indicator/
There was a problem hiding this comment.
We should also add another redirect file from javascript/gauge-charts/ -> javascript/indicator/
| permalink: javascript/gauge-charts/ | ||
| description: How to make a D3.js-based circular gauge chart in javascript. | ||
| permalink: javascript/indicator/ | ||
| description: How to make a D3.js-based gauge chart in javascript. | ||
| layout: user-guide | ||
| thumbnail: thumbnail/gauge.jpg | ||
| language: plotly_js |
There was a problem hiding this comment.
We'll need to add page_type: example_index here so that this shows up on the main page with the other financial chart types.
| @@ -1,15 +1,15 @@ | |||
| --- | |||
| title: JavaScript Graphing Library D3.js-based Gauge Charts| Examples | Plotly | |||
| name: Gauge Charts | |||
There was a problem hiding this comment.
Should we change the name and title of this doc to Indicators as well?
| {type: "indicator", value: 200, delta: {reference: 160}, | ||
| gauge: {axis: {visible: false, range: [0, 200]}}, domain: {row: 0, column: 0}}, | ||
| {type: "indicator", value: 120, gauge: {shape: "bullet", axis: {visible: false, range: [-200, 200]}}, | ||
| domain: {x: [0.05, 0.5], y: [0.15, 0.35]}}, |
There was a problem hiding this comment.
The "S" in speed gets a little cut off here. I wonder if it might be better to change the domain to something like [0.1,0.5]
|
@Mahdis-z , I just looked at the guage-charts PR 🙈 so you obviously don't have to worry about the redirects (except the redirect_from in this case is probably unnecessary) and the Name/title should be changed to indicators. |
| permalink: javascript/gauge-charts/ | ||
| description: How to make a D3.js-based circular gauge chart in javascript. | ||
| permalink: javascript/indicator/ | ||
| description: How to make a D3.js-based gauge chart in javascript. | ||
| layout: user-guide | ||
| thumbnail: thumbnail/gauge.jpg |
There was a problem hiding this comment.
Since we have another doc using the gauge thumbnail, we should create a new one for this doc.
+1 |
| @@ -1,70 +0,0 @@ | |||
| --- | |||
| name: Circular Gauge Chart | |||
There was a problem hiding this comment.
I think we should only remove this doc from #1427.
No description provided.