Skip to content

escape xml in example code blocks #1299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2019
Merged

escape xml in example code blocks #1299

merged 1 commit into from
Apr 23, 2019

Conversation

michaelbabyn
Copy link
Contributor

resolves #967 by escaping html in all example codeblocks.

@michaelbabyn michaelbabyn added the ReviewReady This PR is ready for review label Apr 12, 2019
@michaelbabyn michaelbabyn requested a review from cldougl April 12, 2019 14:46
cldougl
cldougl approved these changes Apr 23, 2019
View reviewed changes
Copy link
Member

@cldougl cldougl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃
looks great

@cldougl cldougl removed the ReviewReady This PR is ready for review label Apr 23, 2019
@michaelbabyn michaelbabyn merged commit 56aeb65 into source-design-merge Apr 23, 2019
@michaelbabyn michaelbabyn deleted the escape-html-in-codeblocks branch April 23, 2019 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cldougl cldougl cldougl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTML isn't getting escaped in this example
2 participants
@michaelbabyn @cldougl