Add GitHub stars To Homepage #1123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdamiba
requested review from
cldougl
and removed request for
nicolaskruchten
|
I would like to add some space between the stars and the name of the library, but I'm having trouble getting css styles to load. |
|
What kind of trouble?
…On Tue, Oct 9, 2018 at 23:59 Joseph Damiba ***@***.***> wrote:
I would like to add some space between the stars and the name of the
library, but I'm having trouble getting css styles to load.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#1123 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAMbA3-2x9lA4bawCRwPaOF-Lq6iuxMXks5ujXB-gaJpZM4XUDvq>
.
|
|
I put the github stars into their own div and added a css class to It seems that the styles in the github-stars CSS class are not being applied- the extra space is as a result of the markup. |
|
|
|
(fyi @nicolaskruchten the class issue got resolved if you're just following this thread via email ) |
|
Poor Matlab and its dismal star score :)
…On Wed, Oct 10, 2018 at 14:07 Joseph Damiba ***@***.***> wrote:
Merged #1123 <#1123> into
source-design-merge.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1123 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAMbAycT5xQzl3E4bbfo6uY4USOVtGotks5ujjd0gaJpZM4XUDvq>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/plotly/plotly-next/issues/159