Skip to content

make ff-subplot doc python3 compatible #1116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 10, 2018
Merged

Conversation

Kully
Copy link
Contributor

@Kully Kully commented Oct 4, 2018

resolves: #1107

@Kully Kully added the ReviewReady This PR is ready for review label Oct 4, 2018
@Kully
Copy link
Contributor Author

Kully commented Oct 4, 2018

@cldougl

Copy link
Member

@cldougl cldougl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small syntax change request then this is good to merge
💃


<div class="output_html rendered_html output_subarea output_execute_result">
<iframe id="igraph" scrolling="no" style="border:none;" seamless="seamless" src="https://plot.ly/~PythonPlotBot/461.embed" height="530px" width="100%"></iframe>
<iframe id="igraph" scrolling="no" style="border:none;" seamless="seamless" src="https://plot.ly/~jordanpeterson/1337.embed" height="530px" width="100%"></iframe>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kully in the future let's all use thePythonPlotBot user for these docs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im rerunning the examples with the PlotBot account

@@ -158,7 +163,7 @@
"cell_type": "markdown",
"metadata": {},
"source": [
"Add the data and layout objects:"
"Combine the data and layout objects to a new figure"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say:

  • Combine the data and layout objects:
    or
  • Combine the data and layout objects to create a figure

@cldougl cldougl removed the ReviewReady This PR is ready for review label Oct 10, 2018
@Kully Kully merged commit 4f242e4 into source-design-merge Oct 10, 2018
@Kully Kully deleted the ff-subplot-update branch October 10, 2018 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python: Update figure-factory-subplots for plotly.py version 3
3 participants