Skip to content

Colorway example #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 10, 2018
Merged

Colorway example #1112

merged 5 commits into from
Oct 10, 2018

Conversation

michaelbabyn
Copy link
Contributor

resolves #1108

@michaelbabyn michaelbabyn added the ReviewReady This PR is ready for review label Oct 3, 2018
@michaelbabyn michaelbabyn requested a review from cldougl October 3, 2018 18:37
cldougl
cldougl approved these changes Oct 10, 2018
View reviewed changes
Copy link
Member

@cldougl cldougl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice example 🌈

just a quick request to update the reference to specifically point to the colorway attribute then this is good to merge 💃

_posts/python/style/colorway/colorway.ipynb Outdated
"cell_type": "markdown",
"metadata": {},
"source": [
"See https://plot.ly/python/reference/ for more information and chart attribute options!"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this reference point to: https://plot.ly/python/reference/#layout-colorway for more information about the colorway attribute

_posts/r/style/2018-10-03-colorway.Rmd Outdated

#Reference

See [https://plot.ly/r/reference](https://plot.ly/r/reference) for more information and chart attribute options!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same: https://plot.ly/r/reference/#layout-colorway

@cldougl cldougl removed the ReviewReady This PR is ready for review label Oct 10, 2018
@michaelbabyn michaelbabyn merged commit cc00176 into source-design-merge Oct 10, 2018
@michaelbabyn michaelbabyn deleted the colorway-example branch October 10, 2018 19:34
@michaelbabyn michaelbabyn mentioned this pull request Oct 10, 2018
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cldougl cldougl cldougl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

colorway example in style section
2 participants
@michaelbabyn @cldougl