Skip to content

projections 3d doc is python3 and plotly3 friendly #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2018

Conversation

Kully
Copy link
Contributor

@Kully Kully commented Sep 27, 2018

fixes: #1099

also fixes some plotly3.0 ValueErrors thrown for invalid x, y, z arrays (numpy.ndarrays)

ready for review

@Kully Kully added the ReviewReady This PR is ready for review label Sep 27, 2018
@Kully
Copy link
Contributor Author

Kully commented Sep 27, 2018

@jonmmease

Copy link
Member

@cldougl cldougl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@cldougl cldougl removed the ReviewReady This PR is ready for review label Oct 3, 2018
@Kully Kully merged commit 752a867 into source-design-merge Oct 3, 2018
@Kully Kully deleted the projections-py3-friendly branch October 3, 2018 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make 2d-projection-of-3d-surface Python 3 compatible.
3 participants