Pyramid chart #1062
Pyramid chart #1062
Conversation
| "metadata": {}, | ||
| "source": [ | ||
| "#### Population Pyramid Chart Using go.Bar\n", | ||
| "If your starting with binned data, use a `go.Bar` trace." |
| "metadata": {}, | ||
| "source": [ | ||
| "#### Population Pyramid Using go.Histogram\n", | ||
| "If you want to quickly create a Population Pyramid from raw data, try `go.Histogram`" |
There was a problem hiding this comment.
add a period at the end of this line.
| ], | ||
| "source": [ | ||
| "import plotly.plotly as py\n", | ||
| "import plotly.graph_objs as go\n", |
There was a problem hiding this comment.
insert space between plotly and non-plotly packages to be consistent with style guide
| ], | ||
| "source": [ | ||
| "import plotly.plotly as py\n", | ||
| "import plotly.graph_objs as go\n", |
There was a problem hiding this comment.
insert space between plotly and non-plotly packages to be consistent with style guide
| ], | ||
| "source": [ | ||
| "import plotly.plotly as py\n", | ||
| "import plotly.graph_objs as go\n", |
There was a problem hiding this comment.
insert space between plotly and non-plotly packages to be consistent with style guide
| "! pip install git+https://github.com/plotly/publisher.git --upgrade\n", | ||
| "import publisher\n", | ||
| "publisher.publish(\n", | ||
| " 'pyramid-charts.ipynb', 'python/population-pyramid/', 'Python Population Pyramid Charts | plotly',\n", |
| "publisher.publish(\n", | ||
| " 'pyramid-charts.ipynb', 'python/population-pyramid/', 'Python Population Pyramid Charts | plotly',\n", | ||
| " 'How to make Population Pyramid Charts in Python with Plotly.',\n", | ||
| " title = 'Population Pyramid Charts | plotly',\n", |
|
Changes look good to me, just need to also add a space between plotly and non-plotly imports. That's all this needs for a 💃 from me. |
| @@ -0,0 +1,292 @@ | |||
| --- | |||
| permalink: python/population-pyramid/ | |||
There was a problem hiding this comment.
population-pyramid -> population-pyramid-charts in the permalink
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "#### Population Pyramid Chart Using go.Bar\n", |
There was a problem hiding this comment.
I'd suggest making this title 'Basic Population Pyramid Chart', I don't think you need the go.Bar as you have the explanation line beneath of using go.Bar for binned data and it may look the side bar look a bit cleaner
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "#### Population Pyramid Using go.Histogram\n", |
There was a problem hiding this comment.
instead of Using go.Histogram it may be more helpful for users to see a title such as: Population Pyramid Binning (ie use binning/bins in the title)
|
|
||
|
|
||
| <div class="output_html rendered_html output_subarea output_execute_result"> | ||
| <iframe id="igraph" scrolling="no" style="border:none;" seamless="seamless" src="https://plot.ly/~michaelbabyn/154.embed" height="525px" width="100%"></iframe> |
There was a problem hiding this comment.
@michaelbabyn can you run this notebook using the PythonPlotBot user so these charts are saved to that account (credentials pinned in the #documentation slack channel)
|
@cldougl , After those last changes is this good to merge? |
create doc for pyramid charts solving this issue