This repository was archived by the owner on Jun 3, 2024. It is now read-only.
Issue 688 - Speed up build for DCC #716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- exclude plotly.js from sourcemap - exclude plotly.js from parsing
| externals, | ||
| module: { | ||
| noParse: /node_modules\/plotly.js/, |
There was a problem hiding this comment.
We know the output of Plotly.js is (1) valid, (2) self-contained (doesn't it to resolve outward facing define/import/require), so don't parse it, just take the file as-is.
| new TerserPlugin({ | ||
| sourceMap: true, | ||
| parallel: true, | ||
| cache: './.build_cache/terser', |
There was a problem hiding this comment.
Two things matter here: (1) the cache folder, (2) source mapping in the minimizer, this allows the devtool plugin to override which chunk will get mapped (vs. devtools prop)
| @@ -52,9 +52,9 @@ module.exports = (env, argv) => { | |||
| library: dashLibraryName, | |||
| libraryTarget: 'window', | |||
| }, | |||
| devtool, | |||
There was a problem hiding this comment.
Now handled by the minimizer. Makes it possible to exclude chunks from mapping
| new WebpackDashDynamicImport(), | ||
| new webpack.SourceMapDevToolPlugin({ | ||
| filename: '[name].js.map', | ||
| exclude: ['async~plotlyjs'] |
There was a problem hiding this comment.
source mapping plotlyjs accounted for the majority of the build time (15s to build + 30s to map non-plotlyjs chunks + 30s to parse plotlyjs + 3.5mn to map plotlyjs)
This was referenced Dec 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #688
On my local machine, build time for DCC goes from ~5 minutes down to ~45 seconds for a no-cache rebuild and ~18 seconds for a "with cache" rebuild.
From the perspective of a DCC user or developer, having access to the Plotly.js sourcemap is of little practical value in most scenarios.