Skip to content
This repository was archived by the owner on Jun 3, 2024. It is now read-only.

Insert style-loader loaded CSS at top of <head/> #382

Merged
merged 13 commits into from
Nov 21, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
## [0.38.1] - 2018-11-21
### Fixed
- Refactored the way the Graph component would generate an unique id if none provided.
- Default CSS imported via `style-loader` is now placed at top, so that user supplied CSS can overwrite it, fixes [#380](https://github.com/plotly/dash-core-components/issues/380)

## [0.38.0] - 2018-11-07
### Fixed
Expand Down
10 changes: 5 additions & 5 deletions dash_core_components/dash_core_components.dev.js

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dash_core_components/dash_core_components.min.js

Large diffs are not rendered by default.

6 changes: 5 additions & 1 deletion test/IntegrationTests.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,11 @@ def setUpClass(cls):
options.binary_location = os.environ['DASH_TEST_CHROMEPATH']

cls.driver = webdriver.Chrome(chrome_options=options)
loader = percy.ResourceLoader(webdriver=cls.driver)
loader = percy.ResourceLoader(
webdriver=cls.driver,
base_url='/assets',
root_dir='test/assets'
)
cls.percy_runner = percy.Runner(loader=loader)
cls.percy_runner.initialize_build()

Expand Down
4 changes: 4 additions & 0 deletions test/assets/testing.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
.test-input-css input {
width: 420px;
border-color: hotpink;
}
10 changes: 10 additions & 0 deletions test/test_integration.py
Original file line number Diff line number Diff line change
Expand Up @@ -1320,3 +1320,13 @@ def on_ts(ts, data):
list_btn.click()
time.sleep(1)
self.wait_for_text_to_equal('#output', json.dumps(nested_list))

def test_user_supplied_css(self):
app = dash.Dash(assets_folder='test/assets')

app.layout = html.Div(className="test-input-css", children=[dcc.Input()])

self.startServer(app)

self.wait_for_element_by_css_selector('.test-input-css')
self.snapshot('styled input - width: 100%, border-color: hotpink')
3 changes: 3 additions & 0 deletions webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,9 @@ module.exports = (env, argv) => {
use: [
{
loader: 'style-loader',
options: {
insertAt: 'top'
}
},
{
loader: 'css-loader',
Expand Down