-
-
Notifications
You must be signed in to change notification settings - Fork 143
Update npm scripts used for building, testing, etc. #299
Changes from all commits
bbea467
be3f77c
18cd646
3f29c40
e4e5401
2036d57
3e0227e
a436282
cc18989
39fff7c
3c725f4
d4e629b
ef19b7b
0c21e7e
ff13335
20262d1
681131c
005353d
639fb58
f3b263f
d1dcf14
0c2a36a
07c04cc
8ef8c0b
1ac226c
a9c1c19
06bd4b5
b838942
66f5042
46268c9
0c17be0
55200cc
64a492a
f007208
97b78e6
d02fc53
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,4 @@ | ||
{ | ||
"extends": "./node_modules/dash-components-archetype/config/babel/babelrc", | ||
"plugins": [ | ||
"styled-jsx/babel" | ||
] | ||
} | ||
"presets": ["env", "react"], | ||
"plugins": ["transform-object-rest-spread", "styled-jsx/babel"] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,17 +34,22 @@ jobs: | |
paths: | ||
- "venv" | ||
- "node_modules" | ||
|
||
- run: | ||
name: prettier --list-different | ||
command: npm run format:test | ||
|
||
- run: | ||
name: npm run lint | ||
command: npm run lint | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. and There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We could do that. That will mean that, if you haven't formatted properly, the build will fail, right? In that case, we're still running Prettier here and enforcing formatting - wouldn't it be better/nicer/friendlier to, instead of having the build fail (and forcing users to run formatting themselves), auto-format it in this step? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Correct, similar to the
How would it get added to the code though? Would CircleCI commit it back to this branch? I'd rather that CI didn't make any changes to the code, that the user is forced to make the changes. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I thought that code pushed to Github would pass through CircleCI first, so whatever changes happen in CircleCI would be reflected on Github. But now that I think about it, I guess that's not how it works. Ok! I'll add the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, CircleCI just runs a copy of the code in the repo at each commit, CircleCI doesn't write back to GitHub at all (unless you program to do that explicitly) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes and that would be too magical. I would expect the code I write to be the code that ends up in Github :) |
||
- run: | ||
name: Build | ||
command: | | ||
. venv/bin/activate | ||
npm run build:js | ||
npm run build:py | ||
|
||
- run: | ||
name: npm test | ||
command: npm test | ||
|
||
- run: | ||
name: Run tests | ||
command: | | ||
|
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In our
dash-component-boilerplate
, we don't have thisplugins
anymore. Do we still need it? If so, should we add it to thedash-component-boilerplate
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We definitely need
styled-jsx/babel
here because of it's dependency in theTabs
component.transform-object-rest-spread
is also needed if we want to use the object spread operator