Feature Request: Arduino bugfix v.2.5.1 is released

[Jason2866]

Since v.2.5.1 is released could you please update to this version?
Thx!

[ivankravets]

@valeros could you investigate why does not work the latest source code v2.5.1 of Arduino core? it builds OK but does not work after flashing.

@d-a-v, @earlephilhower do we have critical changes in 2.5.1 build process? Do we need to upgrade to the latest ESP8266 toolchain and switch off from esptool-ck to esptool-py? Thanks!

[earlephilhower]

@ivankravets There was a linking change (.text into .text and .text1 segment to allow moving some specific functions to IRAM as needed for IRQ callbacks) but I think we already got you in the loop on it.

esp8266/Arduino#5922

[Jason2866]

@ivankravets @valeros
I get a working build with old and new xtensa build chain. No problem with arduino core.
You can take a look here:
platform = https://github.com/Jason2866/platform-espressif8266.git#Stage-Tasmota
for new extensa build chain platformio.py has to be adapted (linked files has to be reordered)
https://github.com/Jason2866/TDM/blob/master/platformio.py
and old Xtensa build chain
platform = https://github.com/Jason2866/platform-espressif8266.git#Tasmota

Core 2.5.1 is used in Project Tasmota with Platformio. You can try online:
Tasmota via gitpod

[mcspr]

Just to make clear what "linked files has to be reordered" means, see
Core 2.5.0 / platform 2.0.0 issue: #128 (comment) (and further comments)
workaround for that: mcspr/platformio-core@708eff2

[ivankravets]

@mcspr why do you need this hook mcspr/platformio-core@708eff2 ?

[Jason2866]

Without this hook, code doesnt boot when builded with new xtensa build chain.
@mcspr thx for you fix, searched the orig. issue and didnt found

[mcspr]

Yes, like @Jason2866 said - updated toolchain seemingly treats -Wl,-T and just -T differently.
esp8266/Arduino never encountered that, because platform.txt / arduino-builder only uses -T{user_selected_ldscript}

[ivankravets]

@Jason2866 @mcspr this is a bug with ESP8266 toolchain. Please file an issue here https://github.com/earlephilhower/esp-quick-toolchain and I'm sure @earlephilhower will take a look.

See GCC docs https://gcc.gnu.org/onlinedocs/gcc/Link-Options.html

-Wl,option
Pass option as an option to the linker. If option contains commas, it is split into multiple options at the commas. You can use this syntax to pass an argument to the option. For example, -Wl,-Map,output.map passes -Map output.map to the linker. When using the GNU linker, you can also get the same effect with -Wl,-Map=output.map.

PlatformIO Core is used for over 30 dev/platform which depend on the different toolchains. It would be great if we can keep PlatformIO Core compatible with GCC CLI.

[earlephilhower]

Guys, the toolchain got bumped in 2.5.0 and was not touched significantly for 2.5.1 AFAIR. Was 2.5.0 working?

If so, then I really think it's something else because we're building the unadulterated GNU sources for the vast majority of things (minor patches, unrelated to the linker).

Just checked, the last time the toolchain was released was Dec 14 2018. Ardui9no 8266 2.5.0 came out in Feb 2019.

[Jason2866]

@earlephilhower the toolchain from 2.5.0 is working fine for 2.5.1 with this change from @mcspr

[ivankravets]

@earlephilhower the bug was introduced in this release https://github.com/earlephilhower/esp-quick-toolchain/releases/tag/2.5.0-3

We use a toolchain that was before "2.5.0-3". The latest "2.5.0-3" breaks ESP8266 SDKs which we support in PlatformIO.

[earlephilhower]

@ivankravets what is the exact version you have been using? Again, we are building the plain GCC code here so there's not much I expect to be able to track down. Patches are kept in a separate dir in the repo, and none relate to the g++/ld options parsing...