-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add useState example #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add useState example #128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one little change
README.md
Outdated
```tsx | ||
import * as React from 'react'; | ||
|
||
interface CounterProps { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use type Props
from now on for new components, I'll be refactoring all existing one to that too
@piotrwitek I fixed according to your review! please confirm!:pray: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great, merging 🎉
resolve #120