Add the example for useContext #127
Conversation
| interface State { | ||
| theme: Theme['theme']; | ||
| theme: Theme; | ||
| } | ||
| export class App extends React.Component<{}, State> { |
There was a problem hiding this comment.
Please rename to ThemeProvider
| import * as React from 'react'; | ||
| import ThemeContext from './theme-context'; | ||
|
|
||
| interface ThemedButtonProps {} |
There was a problem hiding this comment.
I would like to refactor all the interface ThemedButtonProps to just type Props =. I prefer that now as it is more concise and cleaner, also has a benefit to do things like this:
type Props = typeof dispatchProps & ReturnType<typeof mapStateToProps>;Please could you do it for all the components related to this PR?
There was a problem hiding this comment.
Looks good! I can:+1:
|
@sosukesuzuki regarding context, no reason, I was planning to add it eventually but just didn't have enough time to do that until now. But it would be really great if you could add it as well as you have already done most of the work needed to finish it. Now we just need to create a new sub-section in Then please inject in README_SOURCE all the 3 related context examples and the list would go like this: - ThemeContext- ThemeProvider- ThemeConsumer
|
|
@piotrwitek I fixed according to your reviews! please confirm!:pray: I have understood how you are thinking about examples for Context API. |
|
@sosukesuzuki Yeah sure sounds good to me 👍 and great job! |
resolve #120 (comment) - divide `playground/src/context/theme-provider.tsx` to `theme-provider.tsx`, `theme-consumer.tsx` and `theme-context.ts`. - add the example for `useContext` to `playground/src/hooks/use-theme-context.tsx`.
resolve #120 (comment)
playground/src/context/theme-provider.tsxtotheme-provider.tsx,theme-consumer.tsxandtheme-context.ts.useContexttoplayground/src/hooks/use-theme-context.tsx.Do you have a reason that
playground/src/context/theme-providerhave not been add to README? If you don't have any reason, I think that we should add it to README.