Skip to content

increase tooltip font size #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 16, 2018
Merged

increase tooltip font size #14

merged 2 commits into from
Jan 16, 2018

Conversation

ctf0
Copy link
Contributor

@ctf0 ctf0 commented Jan 16, 2018

  • go to def should have more space under it
  • find a way to make the tooltip taller when there are more than one item

demo

@pichillilorenzo
Copy link
Owner

Thanks! ok!

@pichillilorenzo pichillilorenzo merged commit eb6bc70 into pichillilorenzo:master Jan 16, 2018
@pichillilorenzo
Copy link
Owner

@ctf0 Something like this?
schermata 2018-01-16 alle 20 09 00

@ctf0
Copy link
Contributor Author

ctf0 commented Jan 17, 2018

yes yes yes

pichillilorenzo added a commit that referenced this pull request Jan 17, 2018
@pichillilorenzo
Copy link
Owner

@ctf0 released new version 0.13.11 with that update 👍

@ctf0
Copy link
Contributor Author

ctf0 commented Jan 17, 2018

btw, how exactly go to def works, is shows up even if the tooltip have something like string => string is that normal ?

@pichillilorenzo
Copy link
Owner

pichillilorenzo commented Jan 17, 2018

mmmm yeah.. at the moment there isn't a check about that. It shows up in every tooltip, but I will try to manage that! the problem is that for example on this:

var number = 3;

number

It will shows up with number => number on number variable and it works like expected, but going with the mouse on the 3, it shows up anyway with the same thing.. so it is difficult manage that.

@ctf0
Copy link
Contributor Author

ctf0 commented Jan 17, 2018

maybe we can check if its anything other than string , or flow doesnt support that ?

@pichillilorenzo
Copy link
Owner

I think yes (In fact I need to check about that because I don't remember), but at this moment my time is very limited due to University exams 😞 .. However later I will try to check that 👍

@pichillilorenzo
Copy link
Owner

@ctf0 Done! Now tooltip wont show up on quoted strings and numeric constants.
Furthermore the plugin is now available on Package Control 😄

@ctf0
Copy link
Contributor Author

ctf0 commented Jan 22, 2018

focken awesoooooooome 💥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants