How to install flow typings?

[monovertex]

I'm trying to follow the instructions at https://github.com/pichillilorenzo/JavaScriptEnhancements/wiki/Adding-new-definitions-with-flow-typed, but I'm a bit stumped.

I do not have the Flow menu entry and using flow-typed install manually in my project won't work, as I don't have flow as a dependency to the project itself.

Is there any other package supposed to be installed to get the mentioned menu entry?

[pichillilorenzo]

did you create the project using the plugin? This menu option is available only with javascript enhancements projects.. if you want use it in an existing project, follow these simple steps https://github.com/pichillilorenzo/JavaScriptEnhancements/wiki/Using-it-with-an-existing-project

After flow typing installation, try to restart sublime text if it doesn't work after a while and let me know! thanks

[monovertex]

Yes, I did follow the instructions and installed it for an existing project and restarted Sublime (a couple of times).

Here are the menu entries I have:

Let me know if I can provide any other information.

[pichillilorenzo]

Are there errors in the Sublime Text console?? what kind of project did you create? an empty project?

[monovertex]

No, I created a JavaScript project for an existing one, with the instructions in the Wiki link you posted above.

Regarding errors, here's the output when starting Sublime with that project (I can't see any relevant error).

startup, version: 3143 linux x64 channel: stable
executable: /opt/sublime_text/sublime_text
working dir: /
packages path: /home/cosmin/.config/sublime-text-3/Packages
state path: /home/cosmin/.config/sublime-text-3/Local
zip path: /opt/sublime_text/Packages
zip path: /home/cosmin/.config/sublime-text-3/Installed Packages
ignored_packages: ["All Autocomplete", "JavaScript", "SCSS", "Vintage"]
Errors parsing theme:
icon_file_type is missing layer0.opacity, setting to 1.0 for backwards compatibility
pre session restore time: 1.3153
loading dictionary Packages/Language - English/en_US.dic
startup time: 1.70111
first paint time: 1.75456
reloading plugin Default.auto_indent_tag
reloading plugin Default.block
reloading plugin Default.comment
reloading plugin Default.convert_syntax
reloading plugin Default.copy_path
reloading plugin Default.delete_word
reloading plugin Default.detect_indentation
reloading plugin Default.duplicate_line
reloading plugin Default.echo
reloading plugin Default.exec
reloading plugin Default.fold
reloading plugin Default.font
reloading plugin Default.goto_line
reloading plugin Default.history_list
reloading plugin Default.indentation
reloading plugin Default.install_package_control
reloading plugin Default.kill_ring
reloading plugin Default.mark
reloading plugin Default.new_templates
reloading plugin Default.open_context_url
reloading plugin Default.open_in_browser
reloading plugin Default.pane
reloading plugin Default.paragraph
reloading plugin Default.paste_from_history
reloading plugin Default.profile
reloading plugin Default.quick_panel
reloading plugin Default.run_syntax_tests
reloading plugin Default.save_on_focus_lost
reloading plugin Default.scroll
reloading plugin Default.set_unsaved_view_name
reloading plugin Default.settings
reloading plugin Default.show_scope_name
reloading plugin Default.side_bar
reloading plugin Default.sort
reloading plugin Default.swap_line
reloading plugin Default.switch_file
reloading plugin Default.symbol
reloading plugin Default.transform
reloading plugin Default.transpose
reloading plugin Default.trim_trailing_white_space
reloading plugin Default.ui
reloading plugin CSS.css_completions
reloading plugin Diff.diff
reloading plugin HTML.encode_html_entities
reloading plugin HTML.html_completions
reloading plugin 0_package_control_loader.00-package_control
reloading plugin 0_package_control_loader.01-pygments
reloading plugin 0_package_control_loader.01-ssl-linux
reloading plugin 0_package_control_loader.50-markupsafe
reloading plugin 0_package_control_loader.50-pymdownx
reloading plugin 0_package_control_loader.50-python-markdown
reloading plugin 0_package_control_loader.50-pyyaml
reloading plugin 0_package_control_loader.51-bs4
reloading plugin 0_package_control_loader.51-python-jinja2
reloading plugin 0_package_control_loader.55-jsonschema
reloading plugin 0_package_control_loader.55-mdpopups
reloading plugin A File Icon.A File Icon
reloading plugin AlignTab.aligner
reloading plugin AlignTab.aligntab
reloading plugin AlignTab.hist
reloading plugin AlignTab.parser
reloading plugin AlignTab.table
reloading plugin AlignTab.utils
reloading plugin AlignTab.wclen
reloading plugin AutomaticPackageReloader.package_reloader
reloading plugin BufferScroll.BufferScroll
reloading plugin CSS3.css3_completions
reloading plugin CSS3.rgb_to_hex
reloading plugin Case Conversion.case_conversion
reloading plugin Case Conversion.case_parse
indexing [job 1]: spawning 1 workers to process 1 / 1 files
reloading plugin Colorsublime.colorsublime-plugin
reloading plugin Diffy.diffy
reloading plugin DocBlockr.jsdocs
reloading plugin Emmet.emmet-plugin
reloading plugin GitGutter.plugin
indexing [job 1]: indexed 1 files
reloading plugin Gitignore.gitignore
reloading plugin Google Search.google_search
reloading plugin HTML5.encode_html_entities
reloading plugin HTML5.html_completions
reloading plugin Markdown Preview.MarkdownPreview
reloading plugin Markdown Preview.helper
reloading plugin Markdown Preview.markdown_settings
reloading plugin Markdown Preview.markdown_wrapper
reloading plugin MarkdownLivePreview.MLPApi
reloading plugin MarkdownLivePreview.MarkdownLivePreview
reloading plugin MarkdownLivePreview.devListener
reloading plugin MarkdownLivePreview.escape_amp
reloading plugin MarkdownLivePreview.functions
reloading plugin MarkdownLivePreview.image_manager
reloading plugin MarkdownLivePreview.setting_names
reloading plugin Material Theme.Icons
reloading plugin Material Theme.MT
reloading plugin Origami.origami
reloading plugin Package Control.1_reloader
reloading plugin Package Control.2_bootstrap
reloading plugin Package Control.Package Control
reloading plugin PackageResourceViewer.package_resource_viewer
reloading plugin PackageResourceViewer.package_resources
reloading plugin Select Quoted.select_quotes
reloading plugin SideBarEnhancements.SideBar
reloading plugin SideBarEnhancements.SideBarAPI
reloading plugin SideBarEnhancements.SideBarDefaultDisable
reloading plugin SublimeLinter-contrib-sass-lint.linter
reloading plugin SublimeLinter-contrib-solium.linter
reloading plugin SublimeLinter-eslint.linter
reloading plugin SublimeLinter-pylint.linter
reloading plugin SublimeLinter.__init__
reloading plugin SublimeLinter.busy_indicator_view
reloading plugin SublimeLinter.goto_commands
reloading plugin SublimeLinter.highlight_view
reloading plugin SublimeLinter.log_handler
reloading plugin SublimeLinter.message_view
reloading plugin SublimeLinter.panel_view
reloading plugin SublimeLinter.status_bar_view
reloading plugin SublimeLinter.sublime_linter
reloading plugin Sync View Scroll.syncscroll
reloading plugin Tag.Edit
reloading plugin Tag.Tag
reloading plugin Tag.tag_classes
reloading plugin Tag.tag_close_tag
reloading plugin Tag.tag_close_tag_on_slash
reloading plugin Tag.tag_indent
reloading plugin Tag.tag_insert_as_tag
reloading plugin Tag.tag_lint
reloading plugin Tag.tag_remove
reloading plugin Tag.tag_remove_attributes
reloading plugin TerminalView.TerminalView
reloading plugin TerminalView.exec
reloading plugin TerminalView.gateone_terminal_emulator
reloading plugin TerminalView.linux_pty
reloading plugin TerminalView.pyte_terminal_emulator
reloading plugin TerminalView.sublime_terminal_buffer
reloading plugin TerminalView.sublime_view_cache
reloading plugin TerminalView.utils
reloading plugin jQueryDocs.jQueryDocs
reloading plugin Babel.Babel
reloading plugin ColorPicker.sublimecp
reloading plugin HTML-CSS-JS Prettify.HTMLPrettify
reloading plugin JavaScript Enhancements.main
reloading plugin Pretty JSON.PrettyJson
reloading plugin Pretty JSON.PrettyJsonListeners
reloading plugin Pretty YAML.PrettyYaml
reloading plugin SFTP.SFTP
reloading plugin Sublime Ember CLI.import-path-autocomplete
reloading plugin Sublime Ember CLI.open_test
reloading plugin Sublime Tutor.sublime_tutor
plugins loaded
syncScroll starting
starting flow ide server: ['node', '/home/cosmin/.config/sublime-text-3/Packages/JavaScript Enhancements/node_modules/.bin/flow', 'ide', '--protocol', 'very-unstable', '--from', 'sublime_text', '--root', '...redacted path...']
Emmet: No need to update PyV8
JavaScript Enhancements plugin version: 0.16.12
node.js version: v9.11.1
npm version: 5.6.0

[pichillilorenzo]

this is weird.. there is no error about that.. if you go to the plugin folder, can you find the Main_disabled.sublime-menu file (/src/listeners/flow/Main_disabled.sublime-menu) like here https://github.com/pichillilorenzo/JavaScriptEnhancements/tree/master/src/listeners/flow ??

The plugin, when it detects a javascript enhancements project, enables this file renaming it into Main.sublime-menu in order to get seen in the sublime menu. Also, I re-tested it on linux and it works.

If you create another project, can you see it or not??

[monovertex]

Indeed, I can see it for a new, empty project. Any idea what could block the enabling of this menu for an existing project?

[pichillilorenzo]

open your project and then the sublime text console.
Send these commands (line by line!) to the console and tell me what is the output:

JavaScriptEnhancements = __import__('JavaScript Enhancements')
util = JavaScriptEnhancements.src.libs.util
util.is_javascript_project()
JavascriptEnhancementsEnableFlowMenuEventListener = JavaScriptEnhancements.src.listeners.flow.JavascriptEnhancementsEnableFlowMenuEventListener
JavascriptEnhancementsEnableFlowMenuEventListener.path
JavascriptEnhancementsEnableFlowMenuEventListener.path_disabled
import os
os.path.isfile(JavascriptEnhancementsEnableFlowMenuEventListener.path)
os.path.isfile(JavascriptEnhancementsEnableFlowMenuEventListener.path_disabled)

Thanks

[monovertex]

>>> JavaScriptEnhancements = __import__('JavaScript Enhancements')
>>> util = JavaScriptEnhancements.src.libs.util
>>> util.is_javascript_project()
False
>>> JavascriptEnhancementsEnableFlowMenuEventListener = JavaScriptEnhancements.src.listeners.flow.JavascriptEnhancementsEnableFlowMenuEventListener
>>> JavascriptEnhancementsEnableFlowMenuEventListener.path
'/home/cosmin/.config/sublime-text-3/Packages/JavaScript Enhancements/src/listeners/flow/Main.sublime-menu'
>>> JavascriptEnhancementsEnableFlowMenuEventListener.path_disabled
'/home/cosmin/.config/sublime-text-3/Packages/JavaScript Enhancements/src/listeners/flow/Main_disabled.sublime-menu'
>>> import os
>>> os.path.isfile(JavascriptEnhancementsEnableFlowMenuEventListener.path)
False
>>> os.path.isfile(JavascriptEnhancementsEnableFlowMenuEventListener.path_disabled)
True

Apparently it doesn't see the project as being a JS one. I'm not sure why is that. Is there anything else required for the project to be considered like that except the .je-project-settings folder?

[monovertex]

Ah, I figured it out. I looked at the implementation of the is_javascript_project method and found out that you're expecting the project file to be in the project.

I have mine outside of it, in another folder. However, it doesn't go into the else branch, to check for window.folders(), as it would find the javascript project folder then.

[pichillilorenzo]

it doesn't go in the else branch because it found a sublime project (that I expect when you create a project), so it checks the .je-project-settings folder on the main folder. How is your project structure?

[monovertex]

Yes, but as I said, Sublime doesn't have a requirement to have the .sublime-project file in the main folder. It can be anywhere, so I don't think it's a good idea that the plugin just assumes that. It should check the window.folders anyway, if didn't find the project file.

[pichillilorenzo]

So I can try to look at the root of each window.folders() for a .je-project-settings folder, but it will stop on the first one that it will find

[monovertex]

@pichillilorenzo , I opened PR #49, with my proposal for the update of this method. With it the plugin behaves as expected and adds the Flow submenu in Tools.

[monovertex]

However, now the Add Flow definition action doesn't work. The input appears as it should, I search for the package I want to add typings for, it says Searching for '...' definitions and then it disappears and nothing happens. I don't get a list of typings and I don't get the "not found" message. I tried to search typings for ember and express, same outcome for both of them.