Skip to content

Call v8::RegisterExtension using unique_ptr #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 21, 2019
Merged

Call v8::RegisterExtension using unique_ptr #405

merged 2 commits into from
Jun 21, 2019

Conversation

jalr
Copy link
Contributor

@jalr jalr commented May 10, 2019

Using this fix, I was able to build v8js with v8 version 7.6.57

@stesie
Copy link
Member

stesie commented Jun 21, 2019

Hej jalr, thanks for your contribution. There was one issue left regarding a double-free segfault with the extension related tests. Since php-v8js still was managing the v8::Extension * instance ... however v8 was now expecting to do that on it's own (hence the unique_ptr)

I tried to address that with #415 and will merge once tests are green

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants