Skip to content

Update v8js_methods.cc #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2019
Merged

Update v8js_methods.cc #385

merged 1 commit into from
Feb 12, 2019

Conversation

chrisbckr
Copy link
Contributor

  • require() method: check when Module Loader returns an array (ex: require on a .json file) and map to array to JavaScript

* require() method: check when Module Loader returns an array (ex: require on a .json file) and map to array to JavaScript
@stesie
Copy link
Member

stesie commented Feb 12, 2019

Hej, thanks for your contribution. 👍

And sorry for not noticing this PR earlier on... somehow I didn't notice the notification

@stesie stesie merged commit 148bc50 into phpv8:php7 Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants