Skip to content

Update appveyor.yml for issue 306 #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update appveyor.yml for issue 306 #309

wants to merge 1 commit into from

Conversation

Jan-E
Copy link
Contributor

@Jan-E Jan-E commented Apr 15, 2017

Use these v8js builds: #306 (comment)

@Jan-E Jan-E mentioned this pull request Apr 15, 2017
Closed
@Jan-E
Copy link
Contributor Author

Jan-E commented Apr 22, 2017

@stesie You do not have to merge this PR. But you will have to change the dependencies in the appveyor.yml to merge #307 and fix #306

@stesie
Copy link
Member

stesie commented Apr 22, 2017

Sure, yet haven't found the time to finally do it.

You might have seen that I already incorporated your changes in #307, just some debugging fluff in the appveyor.yml left to remove and then merge.

I've taken your ZIP files, thanks once more for creating those, and removed all the debug stuff to save on traffic

@Jan-E
Copy link
Contributor Author

Jan-E commented Apr 22, 2017

OK. I did not see the changes in #307 yet.

@stesie
Copy link
Member

stesie commented Apr 22, 2017

I've merged your changes with #307 meanwhile, thanks for providing the pre-compiled V8 assets :-)

@stesie stesie closed this Apr 22, 2017
@Jan-E Jan-E deleted the php7-issue-306 branch April 23, 2017 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jan-E @stesie