Don't call ObjectTemplate.Set with Object instances, fixes #230 #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works fine with V8 < 5.2.50 somehow, but is now (properly) detected and causing V8 to bail out. Fixed by always setting templates on other templates and finally use Global-Proxy on context to get the actually created object instances.
|
Build still broken due to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works fine with V8 < 5.2.50 somehow, but is now (properly) detected
and causing V8 to bail out. Fixed by always setting templates on
other templates and finally use Global-Proxy on context to get the
actually created object instances.