Fix tests/var_dump.phpt #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent V8 versions (e.g. 4.8.253 or 4.9.19) consider `IsFunction() = true` for Closure objects from PHP; but earlier versions didn't. This ensures consistent var_dump behaviour (sticking to the behaviour with older V8 versions).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent V8 versions (e.g. 4.8.253 or 4.9.19) consider
IsFunction() = truefor Closure objects from PHP; but earlier versions didn't.This ensures consistent var_dump behaviour (sticking to the behaviour with older V8 versions).
See tests/var_dump.diff of failed test: