2.1.8 introduced bug with count()

[momala454]

Bug report

count() is invalid with a closure when counting a variable passed as reference

playground is not up to date yet

current error :

Comparison operation ">=" between 1 and 10 is always false. 
💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your %configurationFile%.

Code snippet that reproduces the problem

https://phpstan.org/r/c4f1c380-7c64-4ec8-9c89-d8a73b5b5357

Expected output

No error, phpstan think $items length is only 1

Did PHPStan help you today? Did it make you happy in any way?

No response

[ondrejmirtes]

Playground is up to date, please provide a better reproducer.

[momala454]

can you please double check ? I am not able to find out what is happening https://github.com/phpstan/phpstan/pull/12710/files

xx/vendor/bin/phpstan analyse "xx/test.php" --level 10
 1/1 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ -------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   test.php                                                                                                                                    
 ------ -------------------------------------------------------------------------------------------------------------------------------------------- 
  :7     Comparison operation ">=" between 1 and 10 is always false.                                                                                 
         🪪  greaterOrEqual.alwaysFalse                                                                                                              
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon.  
 ------ -------------------------------------------------------------------------------------------------------------------------------------------- 


                                                                                                                        
 [ERROR] Found 1 error                                                                                                  
                                                                                                                        

test.php

<?php

$items = [];
$a = function () use (&$items) {
    $x = 'a';
    $items[] = $x;
    if (count($items) >= 10) {
        var_dump(count($items));
        $items = [];
    }  
};
$i = 0;
while ($i++ <= 100) {
    $a();
}

xx/vendor/bin/phpstan --version
PHPStan - PHP Static Analysis Tool 2.1.8

[ondrejmirtes]

Every commit to 2.1.x immediately updates the playground, see this workflow https://github.com/phpstan/phpstan/actions/workflows/update-playground-runner.yml

If you're unable to reproduce the problem in the playground, create a small reproducing repository that shows the problem.

[ondrejmirtes]

But please note that variables passed by referenfe to closures were never understood well by PHPStan, there is likely an open issue about your problem. But that didn't change recently.

[momala454]

strangely, dumpType does not give me the same thing on playground than in local

<?php

$items = [];
\PHPStan\dumpType($items);
$a = function () use (&$items) {
    $x = 'a';
    if (count($items) >= 10) {
        echo 'bla';
    }
    \PHPStan\dumpType($items);
    $items[] = $x;
    \PHPStan\dumpType($items);
    if (count($items) >= 10) {
        var_dump(count($items));
        $items = [];
    }  
};
$i = 0;
while ($i++ <= 100) {
    $a();
}

outputs

  :4     Dumped type: array{}                                                                                                                        
  :10    Dumped type: list<'a'>                                                                                                                      
  :12    Dumped type: array{'a'}                                                                                                                     
  :13    Comparison operation ">=" between 1 and 10 is always false.                                                                                 
         🪪  greaterOrEqual.alwaysFalse                                                                                                              
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon. 

but playground outputs
https://phpstan.org/r/c3d1691a-11d3-4891-a50b-48fa4abcc188

<html><body>
<!--StartFragment-->
4 | Dumped type: array{}     Non-ignorable
-- | --
10 | Dumped type: list<'a'>     Non-ignorable
12 | Dumped type: non-empty-list<'a'>     Non-ignorable

<!--EndFragment-->
</body>
</html>

does that help ?

[momala454]

adding $items[] = 'a'; right after $items = []; fixes the problem and gives me the same output than playground (at least for the last line)

  :5     Dumped type: array{'a'}           
  :11    Dumped type: non-empty-list<'a'>  
  :13    Dumped type: non-empty-list<'a'>  

edit: also doing this fixes the problem

/** @var list<mixed> */
$items = [];

[ondrejmirtes]

It can be something that changed since 2.1.8 on 2.1.x-dev.

[momala454]

the problem is solved after upgrading to 2.1.x-dev 3eb7f1c

[ondrejmirtes]

So wait for 2.1.9 😊

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.