Use argument types as parameter types for inline closures when assigned #3554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The functionality was introduced in phpstan#1628. It works. But as soon as you use an inline assign expression it breaks. Let's support this case too. Sometimes, you want to call something inline and also use the callback later.
ruudk
force-pushed
the
closure-arg-visitor
branch
from
ea45142 to
87412c6
Compare
|
@ondrejmirtes This one is ready for review. I don't understand the failing tests related to the issues. It complains that it cannot find level10.neon. |
|
@ruudk We can't do much about that. Those issues were created with 2.0.x playground on level 10 but here we are in 1.12.x |
|
Thank you! |
|
Solved #3568 |
ruudk
added a commit
to ruudk/Twig
that referenced
this pull request
Oct 17, 2024
After phpstan/phpstan-src#3554 this now makes it easier for PHPStan to understands what's going on. This will allow TwigStan to handle for loops in v4.
fabpot
added a commit
to twigphp/Twig
that referenced
this pull request
Oct 18, 2024
This PR was merged into the 4.x branch. Discussion ---------- Call For recurseFunc inline After phpstan/phpstan-src#3554 this now makes it easier for PHPStan to understands what's going on. This will allow TwigStan to handle for loops in v4. Commits ------- e4f6bf8 Call For recurseFunc inline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functionality was introduced in #1628. It works. But as soon as you use an inline assign expression it breaks. Let's support this case too.
Sometimes, you want to call something inline and also use the callback later.