Type entity property as `numeric-string` while database column type is `string`

[ruudk]

I have an entity with the following column definition:

    /**
     * @ORM\Column(name="amount", type="string")
     */
    private string $amount;

Now I want to type that property as numeric-string because it will only ever contain numbers anyway.

    /**
     * @var numeric-string
     *
     * @ORM\Column(name="amount", type="string")
     */
    private string $amount;

But I'm getting this error:

Property MyEntity::$amount type mapping mismatch: database can contain string but property expects string.

I don't know how to solve this. Is it even possible?

And is the error message correct? Shouldn't it say:

Property MyEntity::$amount type mapping mismatch: database can contain string but property expects numeric-string.

[ondrejmirtes]

VerbosityLevel here (

phpstan-doctrine/src/Rules/Doctrine/ORM/EntityColumnRule.php

Lines 147 to 165 in d9429f6

	if (!$propertyWritableType->isSuperTypeOf($writableToPropertyType)->yes()) {
	$errors[] = sprintf(
	'Property %s::$%s type mapping mismatch: database can contain %s but property expects %s.',
	$className,
	$propertyName,
	$writableToPropertyType->describe(VerbosityLevel::typeOnly()),
	$property->getWritableType()->describe(VerbosityLevel::typeOnly())
	);
	}
	$propertyReadableType = TypeTraverser::map($property->getReadableType(), $transformArrays);
	if (!$writableToDatabaseType->isSuperTypeOf(in_array($propertyName, $identifiers, true) && !$nullable ? TypeCombinator::removeNull($propertyReadableType) : $propertyReadableType)->yes()) {
	$errors[] = sprintf(
	'Property %s::$%s type mapping mismatch: property can contain %s but database expects %s.',
	$className,
	$propertyName,
	$propertyReadableType->describe(VerbosityLevel::typeOnly()),
	$writableToDatabaseType->describe(VerbosityLevel::typeOnly())
	);
	}

) shouldn't be typeOnly, but instead obtained via getRecommendedLevelByType.

[ruudk]

I'll create a PR to fix that.

[ruudk]

I improved the error message in #188.

But I still wonder how I can let it pass.

I want to type the property as numeric-string while using the default string type for the database column.

[ondrejmirtes]

What's PHPStan telling you here is that Doctrine can inject a non-numeric string into your entity. You really need a custom mapping type to make sure that doesn't happen.

Thank you for the PR!

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.