multiline array shape not merged?

[orklah]

Hi, I have a multiline array shape in a project that doesn't seem to be parsed.

When searching for an answer, I found #33 that do exactly that.

However, as though this was supposed to be merged according to
phpstan/phpstan#2497 (comment)
and
#33 (comment)

The actual commit was pretty empty:
18b0e92

and I can't find the content of the PR on master.

For example:
https://github.com/shmax/phpdoc-parser/blob/17d28cc099984a5ecbbbfb7b102daa45ce1af62f/tests/PHPStan/Parser/TypeParserTest.php#L481
https://github.com/shmax/phpdoc-parser/blob/master/tests/PHPStan/Parser/TypeParserTest.php#L481
should be the same

https://github.com/shmax/phpdoc-parser/blob/17d28cc099984a5ecbbbfb7b102daa45ce1af62f/src/Parser/TypeParser.php#L224
https://github.com/shmax/phpdoc-parser/blob/master/src/Parser/TypeParser.php#L224
too.

Was this reverted afterward?

[ondrejmirtes]

Hi, can you post an example on phpstan.org what doesn't get parsed in your case?

[orklah]

https://phpstan.org/r/5d107a04-a3ad-4415-a151-576236dddbd1

[ondrejmirtes]

It's just that you can't put the newline anywhere. This works: https://phpstan.org/r/22622ed0-2a45-40c0-bb7a-e7567be39fee

[ondrejmirtes]

Also look into the feature of type aliases (https://github.com/phpstan/phpstan/releases/tag/0.12.9), you might like it :)

[orklah]

Thanks :)

Types aliase could indeed be handy for my use-case :)

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.