Apply php-cs-fixer #114
Merged
Apply php-cs-fixer #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigfoot90
force-pushed
the
php-cs-fixer
branch
from
9ba2a38 to
b1f94c3
Compare
Current coverage is 99.92% (diff: 100%)@@ master #114 diff @@
==========================================
Files 53 53
Lines 3770 3765 -5
Methods 184 184
Messages 0 0
Branches 0 0
==========================================
- Hits 3767 3762 -5
Misses 3 3
Partials 0 0
|
bigfoot90
force-pushed
the
php-cs-fixer
branch
from
b1f94c3 to
6a4863e
Compare
nijel
reviewed
Jan 5, 2017
| * @package SqlParser | ||
| * @subpackage Contexts | ||
| * @link https://dev.mysql.com/doc/refman/5.0/en/keywords.html | ||
| * @see https://dev.mysql.com/doc/refman/5.0/en/keywords.html |
There was a problem hiding this comment.
As this file is autogenerated by tools/ContextGenerator.php, it will be overwritted again unless we fix the generator as well.
bigfoot90
force-pushed
the
php-cs-fixer
branch
from
6a4863e to
18989fe
Compare
|
Updated |
|
Merged, thanks for your contribution! |
nijel
added a commit
that referenced
this pull request
Jan 6, 2017
Issue #114 Signed-off-by: Michal Čihař <michal@cihar.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, something have gone wrong, and closed my previous PR #112
Please read my comments anyway.
Note
Updated
.php_csfile, and re-runphp-cs-fixertool@ibennetch @nijel Sorry, haven't read your other repository
phpmyadmin/phpmyadminguidelinesCan we discuss about the coding style here?
I'm not enforcing nothing, in the end you are free to accept and merge this PR or not.