Handling merging formats arrays #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigfoot90
force-pushed
the
formats-merging
branch
from
a8f947e to
00c81ec
Compare
Current coverage is 99.70% (diff: 98.91%)@@ master #111 diff @@
==========================================
Files 53 53
Lines 3738 3776 +38
Methods 180 184 +4
Messages 0 0
Branches 0 0
==========================================
+ Hits 3728 3765 +37
- Misses 10 11 +1
Partials 0 0
|
bigfoot90
force-pushed
the
formats-merging
branch
3 times, most recently
from
0d11dc4 to
bec3463
Compare
bigfoot90
force-pushed
the
formats-merging
branch
from
bec3463 to
88baea9
Compare
|
What are the failing tests? |
|
Merged, thanks for your contribution! PS: The checks on coverage and code quality are there to help us spot problematic code, in your case it was rather caused by bug in PHP coverage... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you want to change a format you have to pass a complete formats array in the options.
By this PR you can now pass a partial array of formats, eg.:
htmlor onyclior onlyfunctionof selected formatsWritten tests to prevent downgrading