Fixed spelling in exception messages #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| throw new ValueFormatException('Can not convert '.var_export($value, true).' to DATE'); | ||
| throw new ValueFormatException('Cannot convert "'.var_export($value, true).' to DATE'); |
There was a problem hiding this comment.
missing closing quote. do you want to continue adding the quote below?
|
i remember we had this discussion before. seems cannot is good, although i thought "can not" would be better. lets do as you propose, but lets fix the rest of the quotes before merging. |
dantleech
force-pushed
the
fixed_exception_messages
branch
from
1708012 to
7308576
Compare
|
Yeah, I vaguely remember having a discussion ages ago now :) For me as a native speaker it looks wierd. I've added quotes for all the exceptions. |
dbu
added a commit
that referenced
this pull request
Oct 6, 2014
Fixed spelling in exception messages
|
seems my old english teacher 20 years ago was drilling me on old style english :-D there might be occurences of this throughout the phpcr / cmf stack... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can not => Cannot