Skip to content

Fixed parenthesis for NOT constraint #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2014
Merged

Fixed parenthesis for NOT constraint #128

merged 1 commit into from
Sep 12, 2014

Conversation

dantleech
Copy link
Member

Added parenthesis for NOT constraint.

@greg0ire
Copy link

The build problem is a timeout problem, so, not that severe I think.

@lsmith77
Copy link
Member

yeah that test case is flaky :(

@lsmith77
Copy link
Member

@dantleech not sure if there is much we can do, but could you look into trying to fix this flakyness?

1) PHPCR\Tests\Util\Console\Command\NodeDumpCommandTest::testCommand
PHP_Invoker_TimeoutException: Execution aborted after 1 second

dbu added a commit that referenced this pull request Sep 12, 2014
Fixed parenthesis for NOT constraint
@dbu dbu merged commit 8320659 into master Sep 12, 2014
@dbu dbu deleted the not_fix branch September 12, 2014 02:57
@dbu
Copy link
Member

dbu commented Sep 12, 2014

so hhvm is slower than the rest ? i re-ran and this time it was fine, so i merged. but if you have any idea how to make that test take less time or split it, please tell. flaky tests are annoying.

@dantleech
Copy link
Member Author

will have a look this week

@greg0ire
Copy link

Tested that on my app, it works like a charm! Thanks a lot for that!

@lsmith77
Copy link
Member

just release 1.2.0-RC2

@greg0ire
Copy link

@lsmith77 : you mean you just release_d_ 1.2.0-RC2 ? I'll be using that, thank you!

@dantleech
Copy link
Member Author

There doesn't seem to be anything immediately apparent. The test is "instantaneous" locally, and is failing when adding the Helperset on the Command or thereabouts. I would need to test it locally with HHVM. Maybe later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants