[POC] Added support for embedding the shell #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| class EmbeddedApplication extends ShellApplication | ||
| { | ||
| public function __construct($name = 'UNKNOWN', $version = 'UNKNOWN') |
There was a problem hiding this comment.
why defining 2 arguments which are ignored ?
There was a problem hiding this comment.
I assumed they were required by the interface, removing.
|
the embedded application should probably set autoExit to false by default (you never want to autoExit if it is embedded) |
| * | ||
| * @var boolean | ||
| */ | ||
| protected $writeConfiguration = true; |
dantleech
added a commit
that referenced
this pull request
Aug 10, 2014
[POC] Added support for embedding the shell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the PHPCR session to be set externally and provides a more minimal application which can be envoked from a "parent" application.