Defaulting to xdg directory for history files #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
interesting. yeah this makes sense to me and your PR only changes behaviour if XDB_DATA_HOME is set.
can you please add a changelog entry, mentioning to move the history folder to the XDB file if the home directory is not the same? people might be confused what happened to their history otherwise...
i suggest to make a new minor version.
|
Sure, I have added a changelog entry with the 1.5.0 version if that's correct. |
dbu
reviewed
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the xdg standard since I was cleaning my home directory.
This makes the history file less accessible, but I think that for a history file this is okay.