Add support for symfony 5 #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that there are BC breaks in SF 5.0 (e.g. the Process component no longer accepts a string as it's first argument), and the tests are not running on this PR - but maybe it's easier to merge it now. |
|
@dantleech thx for the response, will have a look at that later. |
|
oops. should i revert the merge? |
|
If it hasn't been tested might be safer - I merged 5.0 support on Phpbench then realised that it wasn't compatible and reverted.
…On 20 November 2019 17:11:41 CET, David Buchmann ***@***.***> wrote:
oops. should i revert the merge?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#201 (comment)
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
|
@alexander-schranz did you test it manually? any chance you could make the ci work? |
|
SF 5.0 was released about an hour ago :)
…On 21 November 2019 09:36:34 CET, David Buchmann ***@***.***> wrote:
@alexander-schranz did you test it manually? any chance you could make
the ci work?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#201 (comment)
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
|
i reverted in #202 until its sorted out. more than happy to merge a thing that upgrades once we are sure we don't break stuff. |
|
@dantleech where is the Process Component used in this phpcr shell? Couldn't find any appearance of it https://github.com/phpcr/phpcr-shell/search?utf8=%E2%9C%93&q=Process&type= |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.