Skip to content

Command shell:path:change (cd): Allow trailing slash on path #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2018
Merged

Command shell:path:change (cd): Allow trailing slash on path #189

merged 1 commit into from
Aug 13, 2018

Conversation

middlebrain
Copy link
Contributor

The 'cd' command complains if the path ends with a slash. That's annoying.

@middlebrain
Command shell:path:change (cd): Allow trailing slash on path
8f5f1a4 
The 'cd' command complains if the path ends with a slash. That's annoying.
dbu
dbu approved these changes Aug 13, 2018
View reviewed changes
Copy link
Member

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that makes sense and i can't see how this would fail. will merge. thanks for the contribution!

@dbu dbu merged commit c496d93 into phpcr:master Aug 13, 2018
@middlebrain middlebrain deleted the cd_allow_trailing_slash branch September 2, 2018 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@middlebrain @dbu