Allow Symfony 3.0 #180
Merged
Allow Symfony 3.0 #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not so simple -- guess this might be a good time to release 1.0 and only support ~2.8 |
|
yep, go for symfony 2.8. maybe tag the current state as 0.9 to indicate its not a 1.0.0 and that it won't be supported going forward. when used as phar, the symfony version is not that relevant (as long as people are using a maintained version of php and not 5.3 or 5.4) |
| @@ -2,28 +2,25 @@ | |||
| "name": "phpcr/phpcr-shell", | |||
| "description": "Shell for PHPCR", | |||
| "require": { | |||
| "symfony/console": "~2.4", | |||
| "symfony/console": "~2.4|~3.0", | |||
|
@dbu 1.0.0-beta3 is already the "current" state, more or less. |
Different method signature on 2.8 and 3.0 makes overriding this tricky, and I am unsure of the benefits anyway.
| @@ -25,7 +25,7 @@ | |||
| class PhpcrShell | |||
| { | |||
| const APP_NAME = 'PHPCRSH'; | |||
| const APP_VERSION = 'dev-master'; | |||
| const APP_VERSION = '1.0.0-beta4'; | |||
|
Bam |
|
\o/
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.