Added node:list sort order #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantleech
force-pushed
the
node_list_order
branch
from
103efe5 to
bca46d3
Compare
| @@ -38,6 +40,7 @@ protected function configure() | |||
| $this->addOption('properties', null, InputOption::VALUE_NONE, 'List only the properties of this node'); | |||
| $this->addOption('level', 'L', InputOption::VALUE_REQUIRED, 'Depth of tree to show'); | |||
| $this->addOption('template', 't', InputOption::VALUE_NONE, 'Show template nodes and properties'); | |||
| $this->addOption('sort', 's', InputOption::VALUE_REQUIRED, 'Sort properties, one of <comment>asc</comment>, <comment>desc</comment>, or <comment>none</comment>', 'asc'); | |||
There was a problem hiding this comment.
could use ...<comment>'.implode('</comment>, <comment>', self::SORT_OPTIONS).'</comment>...
|
seems good to me. travis is unhappy though. |
dantleech
force-pushed
the
node_list_order
branch
from
bca46d3 to
c7422c2
Compare
|
Failure was because you cannot assign arrays to constants in versions of PHP <5.6 |
dantleech
force-pushed
the
node_list_order
branch
from
c7422c2 to
a0c69b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would fix #142