Skip to content

CND Highlighting extension #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2014
Merged

CND Highlighting extension #10

merged 1 commit into from
Jul 20, 2014

Conversation

dantleech
Copy link
Member

Naive CND highlighter for pigments

aliases = ['cnd']
filenames = ['*.cnd']

tokens = {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can easily (well, patiently) extend this so that it is aware of the node type grammer and then it can act as a validator too..

@dantleech
Copy link
Member Author

@dbu @lsmith77 @wouterj any comments here before I merge?

@wouterj
Copy link

wouterj commented Jul 20, 2014

I do not maintain nor review phpcr docs and I have less knowledge about PHPCR. So I don't really care, but the code looks fine. :)

dbu added a commit that referenced this pull request Jul 20, 2014
@dbu dbu merged commit c4944f4 into master Jul 20, 2014
@dbu dbu deleted the cnd_highlighting branch July 20, 2014 18:42
@dbu
Copy link
Member

dbu commented Jul 20, 2014

very nice!

it seems i still have a notification issue with this repository, i did not see this PR.

@dbu
Copy link
Member

dbu commented Jul 20, 2014

erm, right now this is not going to do anything, right? we will need to identify the places we have cnd code blocks and tell their format i think.

@dantleech
Copy link
Member Author

yeah, right now I do not think there are any places where we show CND. This was related to the Node Types document I was working on, but that stalled, and I thought it would be cool for the spec PR, but thats stalled too.

sure it will come in useful one day :)

@dantleech
Copy link
Member Author

Saying that, this might also make sense as package -- if we map ODM documents to node-types, then we might include CND snippets in the ODM / CMF docs..

@dbu
Copy link
Member

dbu commented Jul 20, 2014

if odm generates its own node types the user will not need to write cnd i think so not sure if we need examples. but if we do, lets extract it at the point where we need it in more than one place. its doc, so we don't have to worry about BC of this snippet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants