Make sure header keys are always lowercase #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can confirm I also have this issue. |
tareqtms
approved these changes
Feb 28, 2020
|
Hello, Unfortunately this is a breaking change. By converting all header keys to lowercase, this no longer works: php-shopify/lib/CurlRequest.php Line 163 in a233b8d I will create a PR which converts the key to lowercase within the getHeader method. |
andyexeter
added a commit
to andyexeter/php-shopify
that referenced
this pull request
Oct 12, 2020
tareqtms
added a commit
that referenced
this pull request
Dec 5, 2020
Fix bug introduced by #143 by lowercasing key in getHeader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since http2 header field names must be lowercase ( https://httpwg.org/specs/rfc7540.html#HttpHeaders ) but if curl uses a lower http version the field names are in mixed case. I noticed as on our live system the prev. and next links couldn't be found as with http1.1 they're in the field
Linkinstead oflink. So it makes sense to always make sure they're lower case for consistency.