Closed
Description
Shopify have introduced a limit on variant creation via API to 1000 per day for stores with over 50,000 variants: https://developers.shopify.com/changelog/api-call-limits-will-be-applied-to-variant-creation.
When this limit is reached the response code is 429 Too Many Requests. This means the following code gets caught in an infinite loop:
php-shopify/lib/CurlRequest.php
Lines 141 to 151 in d3c7f3b
I'm not sure of the best way around this, but I'm happy to submit a PR after some feedback. We could check the response body and throw an exception to break out of the loop? The response body when this limit is hit is:
{
"errors": {
"product": [
"Daily variant creation limit reached. Please try again later. See https://help.shopify.com/en/api/getting-started/api-call-limit for more information about rate limits and how to avoid them."
]
}
}
Metadata
Metadata
Assignees
Labels
No labels