Add progress bar to the run command #441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
commented
Jul 3, 2023
| @@ -10,10 +10,10 @@ | |||
|
|
|||
| final class RenderCommand | |||
| { | |||
| /** @param DocumentNode[] $documents */ | |||
| /** @param iterable<DocumentNode> $documents */ | |||
There was a problem hiding this comment.
iterate returns a generator, but looking at the rest of a project, the fact that getDocuments() is an array is never used.
There was a problem hiding this comment.
I think it should be fine then
|
Maybe we should add commandline flag to hide the progress bar. Like --no-progress. As progress bars can break the console output when this is very verbose. ? |
|
You're right, I'll work on that 👍 |
This adds a progress bar based on how many documents are being processed. This is not always possible depending on the capabilities of the current OutputInterface interface implementation, which it is conditionally created. For instance, when running tests, you get a BufferedOutput, which does not have the section capability.
|
@jaapio done 🙂 |
|
Thanks you rock! |
jaapio
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a progress bar based on how many documents are being processed.
This is not always possible depending on the capabilities of the current
OutputInterfaceinterface implementation, which it is conditionally created.For instance, when running tests, you get a
BufferedOutput, which does not have the section capability.Closes #297