Skip to content

Document --FLAKY-- section of PHPTs #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Sep 13, 2024

The given example might not be the best one, since it actually wouldn't need the --FLAKY-- section, but it's the only one we currently have.

The given example might not be the best one, since it actually wouldn't
need the `--FLAKY--` section, but it's the only one we currently have.
@cmb69
Copy link
Member Author

cmb69 commented Sep 13, 2024

I've planning a couple more updates, including documenting the "flakyif", soon.

@iluuu1994
Copy link
Member

Very nice, thank you :)

@cmb69
Copy link
Member Author

cmb69 commented Sep 17, 2024

I've added a commit to document the "flaky" convention for SKIPIF sections.

@derickr
Copy link
Member

derickr commented Sep 17, 2024

I think it is good to document these (obviously), but as per https://news-web.php.net/php.internals/125482, I think it would be great if we move the docs on qa.php.net into the normal documentation (php/doc-en), or to https://github.com/php/php-src/tree/master/docs ?

@cmb69
Copy link
Member Author

cmb69 commented Sep 17, 2024

@derickr, sure. I haven't changed my mind from https://externals.io/message/125480#125482 (not even from https://externals.io/message/118219). But as long as we haven't agreed on a new home for the docs (it's not only about the home, but also the markup is completely different), I'd like to keep the info on qa.php.net up-to-date.

@iluuu1994
Copy link
Member

As run-tests.php is primarily targeted at php-src and extension developers, https://php.github.io/php-src/ makes the most sense to me. But it makes sense to update this here, before we have anything concrete going on.

@cmb69 cmb69 merged commit 7eaaacf into php:master Sep 18, 2024
@cmb69 cmb69 deleted the cmb/flaky-section branch September 18, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants