Skip to content

Don't skip test on Windows due to missing ext/posix #9886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Nov 3, 2022

ext/posix is not available on Windows, but there is no need to check for root (i.e. elevated privileges) on this platform, either.

ext/posix is not available on Windows, but there is no need to check
for root (i.e. elevated privileges) on this platform, either.
@cmb69 cmb69 requested a review from iluuu1994 November 3, 2022 17:06
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏 You'll need to adjust this accordingly when merging upstream, but you should get a merge conflict.

@cmb69
Copy link
Member Author

cmb69 commented Nov 3, 2022

You'll need to adjust this accordingly when merging upstream, but you should get a merge conflict.

Yeah, I know. :)

@cmb69 cmb69 closed this in 4c35d64 Nov 7, 2022
@cmb69 cmb69 deleted the cmb/gh7875-win branch November 7, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants