Skip to content

Auto-close FRs and PRs as not planned #9681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Oct 6, 2022

As it is now, FRs and PRs are closed after some time of inactivity as completed[1] instead of as not_planned. We change that, what requires us to update to actions/stale@v5.

[1] #8784 (comment)

As it is now, FRs and PRs are closed after some time of inactivity as
`completed`[1] instead of as `not_planned`.  We change that, what
requires us to update to actions/stale@v5.

[1] <php#8784 (comment)>
@cmb69
Copy link
Member Author

cmb69 commented Oct 6, 2022

@iluuu1994, thoughts? I also wonder whether we should remove the close workflows from PHP-8.2, or doesn't it matter to have them there and in "master"?

@TimWolla
Copy link
Member

TimWolla commented Oct 6, 2022

I also wonder whether we should remove the close workflows from PHP-8.2, or doesn't it matter to have them there and in "master"?

Not necessary, scheduled workflows executed based on the default branch (i.e. master). See: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#schedule

Scheduled workflows run on the latest commit on the default or base branch.

Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this makes sense to me.

cmb69 added 2 commits October 6, 2022 17:55
This defaults to `close-issue-reason: not_planned` so we don't need to
set this explicitly.
@cmb69 cmb69 closed this in b87a2e6 Oct 10, 2022
@cmb69 cmb69 deleted the cmb/close-not-planned branch October 10, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants