Skip to content

Always skip randomly failing OCI8 extauth tests #9524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 29 commits into from
Closed

Always skip randomly failing OCI8 extauth tests #9524

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
a19447f
unify tests before fix
mvorisek Sep 11, 2022
323e144
use real host to prevent timeouts
mvorisek Sep 11, 2022
1ed7cc9
DEBUG run 2x 20 tests
mvorisek Sep 11, 2022
b2246cb
DEBUG increase testing timeout
mvorisek Sep 11, 2022
ef6ce31
Revert "DEBUG run 2x 20 tests"
mvorisek Sep 11, 2022
f1544b0
use "mysql" host instead
mvorisek Sep 11, 2022
c131cc6
use "anything.invalid" host
mvorisek Sep 11, 2022
76af0fc
Revert "DEBUG increase testing timeout"
mvorisek Sep 11, 2022
77663d2
DEBUG run 2x 20 tests
mvorisek Sep 11, 2022
9e74767
DEBUG increase testing timeout
mvorisek Sep 11, 2022
9c2b696
DEBUG verify original issue is reproducible
mvorisek Sep 12, 2022
7904827
use "mysql" host instead
mvorisek Sep 12, 2022
015bdb7
use "sql1" host (MSSQL docker) everywhere
mvorisek Sep 12, 2022
8af58b0
use "x.cz" host (domain must be at least 2 chars) everywhere
mvorisek Sep 12, 2022
466ba80
DEBUG test only 'bcmath', 'oci8', 'pdo_oci' ext tests and 1 proc only
mvorisek May 26, 2022
e2147d4
DEBUG dump individual times, rm slow tests
mvorisek Sep 12, 2022
8ca49a6
DEBUG run all tests 4x
mvorisek Sep 12, 2022
4b93033
DEBUG fail + dump delay on 10+ secs
mvorisek Sep 12, 2022
a11bf80
use "sql1" host (MSSQL docker) everywhere
mvorisek Sep 12, 2022
d86f02b
anything?connect_timeout=60&transport_connect_timeout=30
mvorisek Sep 12, 2022
30786fe
anything?connect_timeout=6&transport_connect_timeout=3
mvorisek Sep 12, 2022
0a9dc03
Revert "DEBUG run 2x 20 tests"
mvorisek Sep 11, 2022
6e2bb7e
strace extauth test
mvorisek Sep 12, 2022
f509e38
Revert "Revert "DEBUG run 2x 20 tests""
mvorisek Sep 11, 2022
a0ab112
ltrace -fS
mvorisek Sep 12, 2022
a5fc4e9
strace -k
mvorisek Sep 12, 2022
bad6503
revert all
mvorisek Sep 12, 2022
474c6d7
skip the problematic extauth_xx.phpt tests
mvorisek Sep 12, 2022
7f5a754
the tests are not slow
mvorisek Sep 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/test-linux/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,4 @@ runs:
--offline \
--show-diff \
--show-slow 1000 \
--set-timeout 120
--set-timeout 1200
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/php/php-src/runs/8296934151?check_suite_focus=true#step:11:3157 shows when the issue is hit, there is no OCI8 timeout or the timeout is higher than 10 minutes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on:
https://github.com/mvorisek/php-src/runs/8302900173?check_suite_focus=true#step:15:108
https://github.com/mvorisek/php-src/runs/8302902211?check_suite_focus=true#step:10:117
(with elapsed time dump)

it seems "Test 7" - "Test 10" can take up ~200 seconds / "Test XX"

117 changes: 117 additions & 0 deletions .github/workflows/push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,125 @@ jobs:
include:
- debug: true
zts: false
i: 0
- debug: true
zts: false
i: 1
- debug: true
zts: false
i: 2
- debug: true
zts: false
i: 3
- debug: true
zts: false
i: 4
- debug: true
zts: false
i: 5
- debug: true
zts: false
i: 6
- debug: true
zts: false
i: 7
- debug: true
zts: false
i: 8
- debug: true
zts: false
i: 9
- debug: true
zts: false
i: 10
- debug: true
zts: false
i: 11
- debug: true
zts: false
i: 12
- debug: true
zts: false
i: 13
- debug: true
zts: false
i: 14
- debug: true
zts: false
i: 15
- debug: true
zts: false
i: 16
- debug: true
zts: false
i: 17
- debug: true
zts: false
i: 18
- debug: true
zts: false
i: 19

- debug: false
zts: true
i: 0
- debug: false
zts: true
i: 1
- debug: false
zts: true
i: 2
- debug: false
zts: true
i: 3
- debug: false
zts: true
i: 4
- debug: false
zts: true
i: 5
- debug: false
zts: true
i: 6
- debug: false
zts: true
i: 7
- debug: false
zts: true
i: 8
- debug: false
zts: true
i: 9
- debug: false
zts: true
i: 10
- debug: false
zts: true
i: 11
- debug: false
zts: true
i: 12
- debug: false
zts: true
i: 13
- debug: false
zts: true
i: 14
- debug: false
zts: true
i: 15
- debug: false
zts: true
i: 16
- debug: false
zts: true
i: 17
- debug: false
zts: true
i: 18
- debug: false
zts: true
i: 19
name: "LINUX_X64_${{ matrix.debug && 'DEBUG' || 'RELEASE' }}_${{ matrix.zts && 'ZTS' || 'NTS' }}"
runs-on: ubuntu-20.04
steps:
Expand Down
25 changes: 11 additions & 14 deletions ext/oci8/tests/extauth_01.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,20 +3,17 @@ Test External Authentication errors with oci_connect
--SKIPIF--
<?php
if (!extension_loaded('oci8')) die ("skip no oci8 extension");
if (substr(PHP_OS, 0, 3) == 'WIN') die("skip feature not available on Windows platforms");
require(__DIR__.'/details.inc');
if (getenv('SKIP_SLOW_TESTS')) die('skip slow tests excluded by request');
if (substr(PHP_OS, 0, 3) == 'WIN') die("skip feature not available on Windows platforms");
?>
--INI--
oci8.privileged_connect=1
--FILE--
<?php

// Run Test

echo "Test 1\n";

$c = oci_connect('/', 'notemtpy', 'anything', null, OCI_CRED_EXT);
$c = oci_connect('/', 'notemtpy', 'x.cz', null, OCI_CRED_EXT);
if (!$c) {
$m = oci_error();
var_dump($m);
Expand All @@ -25,7 +22,7 @@ var_dump($c);

echo "Test 2\n";

$c = oci_connect('notemtpy', 'notemtpy', 'anything', null, OCI_CRED_EXT);
$c = oci_connect('notemtpy', 'notemtpy', 'x.cz', null, OCI_CRED_EXT);
if (!$c) {
$m = oci_error();
var_dump($m);
Expand All @@ -34,7 +31,7 @@ var_dump($c);

echo "Test 3\n";

$c = oci_connect('notemtpy', '', 'anything', null, OCI_CRED_EXT);
$c = oci_connect('notemtpy', '', 'x.cz', null, OCI_CRED_EXT);
if (!$c) {
$m = oci_error();
var_dump($m);
Expand All @@ -43,7 +40,7 @@ var_dump($c);

echo "Test 4\n";

$c = oci_connect('a', 'b', 'c', null, OCI_SYSDBA+OCI_SYSOPER);
$c = oci_connect('a', 'b', 'x.cz', null, OCI_SYSDBA+OCI_SYSOPER);
if (!$c) {
$m = oci_error();
var_dump($m);
Expand All @@ -52,7 +49,7 @@ var_dump($c);

echo "Test 5\n";

$c = oci_connect('a', 'b', 'c', null, OCI_SYSDBA+OCI_SYSOPER+OCI_CRED_EXT);
$c = oci_connect('a', 'b', 'x.cz', null, OCI_SYSDBA+OCI_SYSOPER+OCI_CRED_EXT);
if (!$c) {
$m = oci_error();
var_dump($m);
Expand All @@ -61,7 +58,7 @@ var_dump($c);

echo "Test 6\n";

$c = oci_connect('', '', 'anything', null, OCI_CRED_EXT);
$c = oci_connect('', '', 'x.cz', null, OCI_CRED_EXT);
if (!$c) {
$m = oci_error();
var_dump($m);
Expand All @@ -70,7 +67,7 @@ var_dump($c);

echo "Test 7\n";

$c = oci_connect('/', '', 'anything', null, OCI_CRED_EXT);
$c = oci_connect('/', '', 'x.cz', null, OCI_CRED_EXT);
if (!$c) {
$m = oci_error();
var_dump($m);
Expand All @@ -79,7 +76,7 @@ var_dump($c);

echo "Test 8\n";

$c = oci_connect('/', null, 'anything', null, OCI_CRED_EXT);
$c = oci_connect('/', null, 'x.cz', null, OCI_CRED_EXT);
if (!$c) {
$m = oci_error();
var_dump($m);
Expand All @@ -88,7 +85,7 @@ var_dump($c);

echo "Test 9\n";

$c = oci_connect('/', '', 'd', null, OCI_SYSDBA+OCI_CRED_EXT);
$c = oci_connect('/', '', 'x.cz', null, OCI_SYSDBA+OCI_CRED_EXT);
if (!$c) {
$m = oci_error();
var_dump($m);
Expand All @@ -97,7 +94,7 @@ var_dump($c);

echo "Test 10\n";

$c = oci_connect('/', '', 'd', null, OCI_SYSOPER+OCI_CRED_EXT);
$c = oci_connect('/', '', 'x.cz', null, OCI_SYSOPER+OCI_CRED_EXT);
if (!$c) {
$m = oci_error();
var_dump($m);
Expand Down
22 changes: 10 additions & 12 deletions ext/oci8/tests/extauth_02.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,9 @@ oci8.privileged_connect=1
--FILE--
<?php

// Run Test

echo "Test 1\n";

$c = oci_new_connect('/', 'notemtpy', 'anything', null, OCI_CRED_EXT);
$c = oci_new_connect('/', 'notemtpy', 'x.cz', null, OCI_CRED_EXT);
if (!$c) {
$m = oci_error();
var_dump($m);
Expand All @@ -24,7 +22,7 @@ var_dump($c);

echo "Test 2\n";

$c = oci_new_connect('notemtpy', 'notemtpy', 'anything', null, OCI_CRED_EXT);
$c = oci_new_connect('notemtpy', 'notemtpy', 'x.cz', null, OCI_CRED_EXT);
if (!$c) {
$m = oci_error();
var_dump($m);
Expand All @@ -33,7 +31,7 @@ var_dump($c);

echo "Test 3\n";

$c = oci_new_connect('notemtpy', '', 'anything', null, OCI_CRED_EXT);
$c = oci_new_connect('notemtpy', '', 'x.cz', null, OCI_CRED_EXT);
if (!$c) {
$m = oci_error();
var_dump($m);
Expand All @@ -42,7 +40,7 @@ var_dump($c);

echo "Test 4\n";

$c = oci_new_connect('a', 'b', 'c', null, OCI_SYSDBA+OCI_SYSOPER);
$c = oci_new_connect('a', 'b', 'x.cz', null, OCI_SYSDBA+OCI_SYSOPER);
if (!$c) {
$m = oci_error();
var_dump($m);
Expand All @@ -51,7 +49,7 @@ var_dump($c);

echo "Test 5\n";

$c = oci_new_connect('a', 'b', 'c', null, OCI_SYSDBA+OCI_SYSOPER+OCI_CRED_EXT);
$c = oci_new_connect('a', 'b', 'x.cz', null, OCI_SYSDBA+OCI_SYSOPER+OCI_CRED_EXT);
if (!$c) {
$m = oci_error();
var_dump($m);
Expand All @@ -60,7 +58,7 @@ var_dump($c);

echo "Test 6\n";

$c = oci_new_connect('', '', 'anything', null, OCI_CRED_EXT);
$c = oci_new_connect('', '', 'x.cz', null, OCI_CRED_EXT);
if (!$c) {
$m = oci_error();
var_dump($m);
Expand All @@ -69,7 +67,7 @@ var_dump($c);

echo "Test 7\n";

$c = oci_new_connect('/', '', 'anything', null, OCI_CRED_EXT);
$c = oci_new_connect('/', '', 'x.cz', null, OCI_CRED_EXT);
if (!$c) {
$m = oci_error();
var_dump($m);
Expand All @@ -78,7 +76,7 @@ var_dump($c);

echo "Test 8\n";

$c = oci_new_connect('/', null, 'anything', null, OCI_CRED_EXT);
$c = oci_new_connect('/', null, 'x.cz', null, OCI_CRED_EXT);
if (!$c) {
$m = oci_error();
var_dump($m);
Expand All @@ -87,7 +85,7 @@ var_dump($c);

echo "Test 9\n";

$c = oci_new_connect('/', '', 'd', null, OCI_SYSDBA+OCI_CRED_EXT);
$c = oci_new_connect('/', '', 'x.cz', null, OCI_SYSDBA+OCI_CRED_EXT);
if (!$c) {
$m = oci_error();
var_dump($m);
Expand All @@ -96,7 +94,7 @@ var_dump($c);

echo "Test 10\n";

$c = oci_new_connect('/', '', 'd', null, OCI_SYSOPER+OCI_CRED_EXT);
$c = oci_new_connect('/', '', 'x.cz', null, OCI_SYSOPER+OCI_CRED_EXT);
if (!$c) {
$m = oci_error();
var_dump($m);
Expand Down
Loading