ASAN on push with Cirrus

[iluuu1994]

No description provided.

[devnexen]

system clang has all supported sanitizers, thanksfully since freebsd contributors dearly need those to debug the userland ;-)

[iluuu1994]

@devnexen I'll try FreeBSD later, it stalled for some reason. Adding a separate task for now.

[cmb69]

Hmm, "unable to locate package …" – don't know how to fix. :(

[devnexen]

Is it the debian's fastly mirror ? would adding a second but less solicited mirror be an option ?

[iluuu1994]

would adding a second but less solicited mirror be an option ?

Didn't work. I have no clue what's causing this. If I run the gcc Docker container locally I can install the packages no problem.

[iluuu1994]

It has something to do with the line breaks. I'm now testing with Cirrus' local testing tool, that seems to work quite well.

Edit: I take it back, I get unrelated PCRE errors locally 😝 We're back to debugging by pushing.

[iluuu1994]

The ASAN errors in preload here are caused by the fork and the child-process exiting without cleaning up non-shared memory. Coincidentally this is now fixed by #9473 (as we're preloading with root in CI). Doing any kind of shutdown might be risky if shared memory is accidentally modified so I'm guessing relying on the OS cleaning up the malloced memory is best.

[iluuu1994]

This should be more or less ready. I disabled slow extensions and slow tests. We're running 14734/17696 tests in ~30 minutes which is pretty decent.

[cmb69]

I disabled slow extensions and slow tests.

Disabling slow tests makes perfect sense to me. I'm not sure about disabling slow extensions; at least some important extensions should be checked (I'm particularly thinking of mbstring, mysqli and pdo_mysql). How much longer would that CI job take when we also test these three extensions?

[iluuu1994]

How much longer would that CI job take when we also test these three extensions?

I'll check after work. We'll also need to set up the services in Cirrus which the FreeBSD build that I copied hasn't done yet. My primary motivation for this is to have test things that are regularly changed. Other errors will still be caught in nightly.

[iluuu1994]

@cmb69 Apart from the dl() tests suddenly failing for no reason (:unamused:) the build takes ~15 minutes longer which is fine by me.

[iluuu1994]

Building with Clang is a little faster and is also something we don't already cover. So it makes sense to do that instead.

[cmb69]

Apart from the dl() tests suddenly failing for no reason

Is this related to #9196? Maybe just try without OPcache to see.

[iluuu1994]

Apart from the dl() tests suddenly failing for no reason

Is this related to #9196? Maybe just try without OPcache to see.

RC_DEBUG is not enabled in this build, so probably not. I disabled the dl-test extension for this build for now.