-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Add "Start time" and "Last restart time" to phpinfo() for opcache #9475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
not against the idea personally, makes sense. |
b0422e5
to
695d0cc
Compare
695d0cc
to
996a4e3
Compare
Looks reasonable to me, what do you think @TimWolla ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not my area of expertise, but the output format is good now, the patch looks reasonable to me and if it helps you, I don't see why this shouldn't be included.
@devnexen Agreed; added a review saying so. But this is not my area of expertise, consider this a “small” approval 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but giving it a bit time in case someone wants to jump in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! That info may be useful, so this is good for me. I'd combine the declaration and initialization of the zend_string
s, though (there is no more need to separate declarations and statements).
Merged, thank you ! |
One more piece of verboseness from our repository. When we debug things, sometimes it's useful to know the time of the event.
This adds start/restart/forcerestart timestamps to phpinfo()
Could you please take a look if this might be useful for the community? Let me know if I need to change/add anything.