Skip to content

Add "Start time" and "Last restart time" to phpinfo() for opcache #9475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mikhainin
Copy link
Contributor

@mikhainin mikhainin commented Sep 2, 2022

One more piece of verboseness from our repository. When we debug things, sometimes it's useful to know the time of the event.
This adds start/restart/forcerestart timestamps to phpinfo()

Could you please take a look if this might be useful for the community? Let me know if I need to change/add anything.

@devnexen
Copy link
Member

devnexen commented Sep 2, 2022

not against the idea personally, makes sense.

@devnexen
Copy link
Member

devnexen commented Sep 4, 2022

Looks reasonable to me, what do you think @TimWolla ?

Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not my area of expertise, but the output format is good now, the patch looks reasonable to me and if it helps you, I don't see why this shouldn't be included.

@TimWolla
Copy link
Member

TimWolla commented Sep 4, 2022

@devnexen Agreed; added a review saying so. But this is not my area of expertise, consider this a “small” approval 😃

Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but giving it a bit time in case someone wants to jump in.

Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! That info may be useful, so this is good for me. I'd combine the declaration and initialization of the zend_strings, though (there is no more need to separate declarations and statements).

@devnexen devnexen closed this in 9bea5f4 Sep 5, 2022
@devnexen
Copy link
Member

devnexen commented Sep 5, 2022

Merged, thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants