Remove ZEND_DVAL_TO_LVAL_CAST_OK

[zeriyoshi]

As far as I can see, this operation should always use the slow (right) method, and the results seem to be wrong when ZEND_DVAL_TO_LVAL_CAST_OK is enabled.

I see, this macro seems to be always disabled in Linux / gcc and macOS 10.15 / clang (13.0.0) environments. (If clang is updated, the autoconf check succeeds and it is enabled. The test always fails because it does not work as expected)

Are there cases where this macro is correctly enabled?

Blocker: #9087

[cmb69]

As far as I can see, this operation should always use the slow (right) method, and the results seem to be wrong when ZEND_DVAL_TO_LVAL_CAST_OK is enabled.

Given that casting an out of range float to an integer is undefined behavior, I think you're right.

[iluuu1994]

Should this be back-ported to PHP 8.0?

[cmb69]

Should this be back-ported to PHP 8.0?

I'd say, yes.

[zeriyoshi]

@cmb69
I don't think zend_dval_to_lval_slow is an appropriate name, but since it is declared as ZEND_API, should I keep it?
Also, is it correct that the backport should be up to the version in the Active Support status (PHP 8.0)?

[cmb69]

We need to keep zend_dval_to_lval() anyway, at least for PHP-8.0 and PHP-8.1, so it would make sense to just forward to zend_dval_to_lval_slow() from there. For master, we could actually remove zend_dval_to_lval_slow() (that would need a note in UPGRADING.INTERNALS).

[zeriyoshi]

@cmb69 @iluuu1994
I understand. If there are no objections, I will merge this MR into PHP-8.0 and later at midnight (GMT+9). After that, I will create a PR against master to refactor API.

(I am newbie to this process, so I will @ it just in case)

[cmb69]

@zeriyoshi, yes, that makes sense. But don't forget to still merge upwards (first into PHP 8.1, and then into "master").