Skip to content

intl extension, build fix for icu >= 71.x release. #8930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

intl extension, build fix for icu >= 71.x release. #8930

wants to merge 1 commit into from

Conversation

devnexen
Copy link
Member

@devnexen devnexen commented Jul 5, 2022

ubrk/ucnv_safeClone had been deprecated in favor
of ubrk/ucnv_clone which does not use user provided stacks
but remain thread safe.

cmb69
cmb69 reviewed Jul 6, 2022
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you! Except for the version issue, this looks good to me.

@devnexen
intl extension, build fix for icu >= 71.x release.
c135a7b 
ubrk/ucnv_safeClone had been deprecated in favor
of ubrk/ucnv_clone which does not use user provided stacks
but remain thread safe.
@devnexen devnexen force-pushed the intl_update_for_icu71 branch from 6096835 to c135a7b Compare July 6, 2022 11:47
cmb69
cmb69 approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@devnexen devnexen closed this in b22d2bf Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 approved these changes

Assignees
No one assigned
Labels
Extension: intl Waiting on Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devnexen @cmb69