FPM. access.log with stderr begins to write logs to error_log after daemon reload (GH-8885) #8913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bukka
requested changes
Jul 3, 2022
|
Also I added tests. |
|
Looks good to me but can you squash your changes please ? |
|
@devnexen I can, but as I know github has a checkbox with options "how to merge", including squash option. If it's not an option tell me and I will do it on y side. Thanks. |
|
Lets say I prefer to merge NEWS entry and the changes themselves in one go :) |
bukka
reviewed
Jul 25, 2022
| // php-fpm must not be launched with --force-stderr option | ||
| $tester = new FPM\Tester($cfg, '', [FPM\Tester::PHP_FPM_DISABLE_FORCE_STDERR => true]); | ||
| // getPrefixedFile('err.log') is the same path that returns processTemplate('{{FILE:LOG}}') | ||
| $errorLogFile = $tester->getPrefixedFile('err.log'); |
There was a problem hiding this comment.
It would be better to get this integrated to the tester and introduce something like getErrorLogLines maybe even have something like expectErrorLogLines.
|
In terms of squashing, it is always helpful to have it done as we merge manually to lower branches and add notes to changelog (NEWS). Basically it saves us doing |
bukka
approved these changes
Aug 29, 2022
|
Merged via f92505c |
bukka
added a commit
to bukka/php-src
that referenced
this pull request
Oct 29, 2022
SaltStack uses Python subprocess and redirects stderr to stdout which is then piped to the returned output. If php-fpm starts in daemonized mode, it should close stderr. However a fix introduced in phpGH-8913 keeps stderr around so it can be later restored. That causes the issue reported in phpGH-9754. The solution is to keep stderr around only when php-fpm runs in foreground as the issue is most likely visible only there. Basically there is no need to restore stderr when php-fpm is daemonized.
bukka
added a commit
to bukka/php-src
that referenced
this pull request
Oct 29, 2022
SaltStack uses Python subprocess and redirects stderr to stdout which is then piped to the returned output. If php-fpm starts in daemonized mode, it should close stderr. However a fix introduced in phpGH-8913 keeps stderr around so it can be later restored. That causes the issue reported in phpGH-9754. The solution is to keep stderr around only when php-fpm runs in foreground as the issue is most likely visible only there. Basically there is no need to restore stderr when php-fpm is daemonized.
bukka
added a commit
to bukka/php-src
that referenced
this pull request
Oct 29, 2022
SaltStack uses Python subprocess and redirects stderr to stdout which is then piped to the returned output. If php-fpm starts in daemonized mode, it should close stderr. However a fix introduced in phpGH-8913 keeps stderr around so it can be later restored. That causes the issue reported in phpGH-9754. The solution is to keep stderr around only when php-fpm runs in foreground as the issue is most likely visible only there. Basically there is no need to restore stderr when php-fpm is daemonized.
bukka
added a commit
to bukka/php-src
that referenced
this pull request
Oct 29, 2022
SaltStack uses Python subprocess and redirects stderr to stdout which is then piped to the returned output. If php-fpm starts in daemonized mode, it should close stderr. However a fix introduced in phpGH-8913 keeps stderr around so it can be later restored. That causes the issue reported in phpGH-9754. The solution is to keep stderr around only when php-fpm runs in foreground as the issue is most likely visible only there. Basically there is no need to restore stderr when php-fpm is daemonized.
bukka
added a commit
that referenced
this pull request
Oct 30, 2022
SaltStack uses Python subprocess and redirects stderr to stdout which is then piped to the returned output. If php-fpm starts in daemonized mode, it should close stderr. However a fix introduced in GH-8913 keeps stderr around so it can be later restored. That causes the issue reported in GH-9754. The solution is to keep stderr around only when php-fpm runs in foreground as the issue is most likely visible only there. Basically there is no need to restore stderr when php-fpm is daemonized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8885